Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move tensor to cpu #86

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: move tensor to cpu #86

merged 1 commit into from
Oct 15, 2024

Conversation

stephantul
Copy link
Collaborator

We didn't move the tensor to cpu before trying to dump it, which causes an error if the model is on another device.

@stephantul stephantul requested a review from Pringled October 15, 2024 09:47
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/model.py 96.74% <ø> (ø)

@stephantul stephantul merged commit 5c1ba32 into main Oct 15, 2024
3 checks passed
@stephantul stephantul deleted the fix_dump_when_model_is_on_device branch October 15, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephantul @Pringled